Fix DuckDB connection pool with database path validation#524
Merged
Conversation
- Added a defense-in-depth check to ensure the resolved database path remains within the base directory, raising a ValueError if it escapes the intended directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in the DuckDB connection pool by adding path validation logic. The
DuckDBConnectionPoolnow validates the database file path before attempting to establish connections, preventing errors caused by invalid or missing paths.Key Accomplishments
Breaking Changes
None. This is a purely additive fix that adds validation guards without altering existing public interfaces or behavior for valid paths.
Testing Notes
Infrastructure Considerations
🤖 Generated with Claude Code
Branch Info:
bugfix/duckdb-pool-bugmainCo-Authored-By: Claude noreply@anthropic.com