This repository was archived by the owner on Apr 24, 2023. It is now read-only.
Open
Conversation
oswinso
reviewed
Sep 23, 2019
Contributor
oswinso
left a comment
There was a problem hiding this comment.
changes look good to me, but we'll need to test first before merging
Contributor
|
Oh woops Wednesday we had all hands + some other stuff so we couldn't get to test it out then. Let's aim for the coming Wednesday to test this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the master branch of the velodyne package as a sub module and enables the use of organized clouds to allow for more efficient calculation of normals.
This PR does the following:
Fixes #508
Testing steps (If relevant)
Expectation: Should run normally.
Self Checklist
make format