Skip to content

NetFramework4.8.1 Migration #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arastookhajehee wants to merge 2 commits into
base: master
Choose a base branch
from
Open

NetFramework4.8.1 Migration #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d9a3cd
target upgraded to .NetFramework4.8.1
Arastookhajehee Jan 9, 2026
c0ff4d2
added Newtonsoft.Json for net481
Arastookhajehee Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MachinaBridge/App.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<startup>
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.1"/>
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8.1"/>
</startup>
</configuration>
5 changes: 4 additions & 1 deletion src/MachinaBridge/MachinaBridge.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<AppDesignerFolder>Properties</AppDesignerFolder>
<RootNamespace>MachinaBridge</RootNamespace>
<AssemblyName>MachinaBridge</AssemblyName>
<TargetFrameworkVersion>v4.6.1</TargetFrameworkVersion>
<TargetFrameworkVersion>v4.8.1</TargetFrameworkVersion>
<FileAlignment>512</FileAlignment>
<ProjectTypeGuids>{60dc8134-eba5-43b8-bcc9-bb4bc16c2548};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<WarningLevel>4</WarningLevel>
Expand Down Expand Up @@ -43,6 +43,9 @@
<HintPath>..\packages\System.Windows.Interactivity.WPF.2.0.20525\lib\net40\Microsoft.Expression.Interactions.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL">
<HintPath>..\packages\Newtonsoft.Json.13.0.4\lib\net45\Newtonsoft.Json.dll</HintPath>
</Reference>
Comment on lines +46 to +48
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Newtonsoft.Json assembly reference doesn't include a <Private>True</Private> (Copy Local) element, while the other NuGet references in this project do. Add it for consistency with the existing pattern in this .csproj and to make it explicit that the DLL should be copied to the output folder.

Copilot uses AI. Check for mistakes.
<Reference Include="System" />
<Reference Include="System.Data" />
<Reference Include="System.Drawing" />
Expand Down
2 changes: 1 addition & 1 deletion src/MachinaBridge/Properties/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/MachinaBridge/Properties/Settings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/MachinaBridge/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Newtonsoft.Json" version="13.0.4" targetFramework="net481" />
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Newtonsoft.Json package/reference appears unused in this repository: there are no using Newtonsoft... or JsonConvert usages under src/MachinaBridge. If it isn't required at runtime (e.g., only planned for future work), consider removing it; if it is required transitively, add a short note (e.g., in the PR description or project docs) explaining why it must be a direct dependency.

Suggested change
<package id="Newtonsoft.Json" version="13.0.4" targetFramework="net481" />

Copilot uses AI. Check for mistakes.
<package id="System.Windows.Interactivity.WPF" version="2.0.20525" targetFramework="net461" />
<package id="WebSocketSharp-NonPreRelease" version="1.0.0" targetFramework="net452" />
Comment on lines +3 to 5
Copy link

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages.config still lists the existing NuGet packages with targetFramework set to older frameworks (net461 / net452) even though the project now targets v4.8.1. Update those targetFramework values to net481 to keep the NuGet metadata consistent with the upgraded project target and avoid confusing restores/reinstalls.

Copilot uses AI. Check for mistakes.
</packages>
Loading