Add basic Electron tests and pump its version for demos #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds Electron version display to demo applications and updates Electron from version 31.x to 40.0.0. It also fixes timer parameter types in the turtle_tf2 demo by converting numeric literals to BigInt.
Changes:
- Updated the test command to include Electron tests via
test/electron/run_test.js - Bumped Electron version from ^31.x to ^40.0.0 across all demo package.json files
- Added Electron version display overlays to all demo renderer files
- Fixed timer periods in turtle_tf2/main.js to use BigInt literals (100n, 1000n)
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added Electron installation and test execution to the main test script |
| electron_demo/turtle_tf2/renderer.js | Added process import and Electron version display overlay |
| electron_demo/turtle_tf2/package.json | Bumped Electron version from ^31.7.7 to ^40.0.0 |
| electron_demo/turtle_tf2/main.js | Fixed timer periods to use BigInt literals (100n, 1000n) as required by createTimer API |
| electron_demo/topics/renderer.js | Added Electron version display (missing process import) |
| electron_demo/topics/package.json | Bumped Electron version from ^31.0.0 to ^40.0.0 |
| electron_demo/manipulator/renderer.js | Added process import and dual version displays (floating overlay + HTML elements) |
| electron_demo/manipulator/package.json | Bumped Electron version from ^31.7.7 to ^40.0.0 |
| electron_demo/manipulator/index.html | Added HTML elements for displaying Node.js, Chromium, and Electron versions |
| electron_demo/car/renderer.js | Added Electron version display (missing process import) |
| electron_demo/car/package.json | Bumped Electron version from ^31.0.0 to ^40.0.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Electron version display to demo applications and updates Electron from version 31.x to 40.0.0. It also fixes timer parameter types in the turtle_tf2 demo by converting numeric literals to BigInt.
Changes:
test/electron/run_test.jsFix: #1378