Open
Conversation
evan-palmer
requested changes
Aug 1, 2025
Member
evan-palmer
left a comment
evan-palmer
left a comment
There was a problem hiding this comment.
I just have two small grammar changes. Otherwise, everything looks good. We should test the hardware interface to make sure that it works too. We can do that tomorrow with a dummy controller
evan-palmer
previously approved these changes
Aug 1, 2025
Member
evan-palmer
left a comment
evan-palmer
left a comment
There was a problem hiding this comment.
Looks good! Thanks for making these changes. I'll test it out tomorrow to confirm that it works before merging
Author
|
Sounds good! |
Member
|
I started testing this in the pool yesterday. It didn't work quite as I expected it would, so I am going to do some bench testing later this week to validate it further. |
Author
|
Sounds good! What did you notice while you tested yesterday? |
* Update hardware interface and remove stale teleop package * Update API according to recent upstream deprecations
* Update hardware interface and remove stale teleop package * Update API according to recent upstream deprecations * fix remaining references to teleop packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
The ArduSub
SERVO{N}_FUNCTIONparameters for each thruster are now set toRCIN{N}values instead ofRCPassThruas it was causing a conflict on channel 8 for the BlueROV leading to camera tilt.Testing
Testing done on the BlueROV.