Skip to content

Fix specs of PlaceController #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agnaldo4j wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix specs of PlaceController #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f38461d
Fix specs of PlaceController
agnaldo4j Dec 10, 2020
31e7166
Fix code style
agnaldo4j Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/main/java/br/com/clickbus/challenge/controller/PlaceController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,18 @@
import org.springframework.web.bind.annotation.PutMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;

import javax.validation.Valid;
import java.util.List;

@Api("places")
@RestController
@RequestMapping("places")
public class PlaceController {

@Autowired
private PlaceService service;

@PostMapping
Expand All @@ -44,6 +47,16 @@ public ResponseEntity findAll() {
return ResponseEntity.ok(places);
}

@GetMapping("/")
public ResponseEntity findByName(@RequestParam(value = "name") String name) {
List<Place> result = service.findByName(name);
if (result.isEmpty()) {
return ResponseEntity.notFound().build();
} else {
return ResponseEntity.ok(result);
}
}

@PutMapping("/{id}")
public ResponseEntity alter(@PathVariable Long id, @RequestBody @Valid PlaceDTO placeDTO) {
Place place = service.findById(id).orElseThrow(null);
Expand Down