Replace simple-node-logger with pino for Node 24 compatibility#62
Open
Pratheek555 wants to merge 7 commits intoRocketChat:masterfrom
Open
Replace simple-node-logger with pino for Node 24 compatibility#62Pratheek555 wants to merge 7 commits intoRocketChat:masterfrom
simple-node-logger with pino for Node 24 compatibility#62Pratheek555 wants to merge 7 commits intoRocketChat:masterfrom
Conversation
simple-node-logger with native logger for Node 24 compatibility
KevLehman
suggested changes
Feb 28, 2026
Member
KevLehman
left a comment
There was a problem hiding this comment.
Just use pino or a log library, no need to reinvent the wheel
Author
yes sir, I already have it implemented in another branch. Will push the code in sometime. thank you! |
simple-node-logger with native logger for Node 24 compatibilitysimple-node-logger with pino for Node 24 compatibility
Author
|
Hey @KevLehman I have implemented pino with pino-pretty. The below shows the demonstration of the logs while compiling an app. Please do let me know if any changes are required.
Thank you for your time! |
Dnouv
reviewed
Mar 2, 2026
Dnouv
reviewed
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR replaces
simple-node-loggerusage with a native in-repo logger implementation insrc/misc/logger.ts.Fixes
#61
Why
simple-node-loggeris causing runtime compatibility issues on modern Node versions (notably Node 24), including crashes from deprecated/removed NodeutilAPIs.Switching to a small native logger removes that runtime risk and avoids external logger dependency behavior.
What changed
NativeLoggerwith:setLevel()supporttrace,debug,info,warn,error,fatal)debug,info,warn,errormethods[YYYY-MM-DD HH:mm:ss.SSS] LEVEL ...argsprocess.env.LOG_LEVEL(defaulting toinfo)The below logs were obtained while trying to compile a rocketchat app.
Before logs: (ran by switching node version to 20)
After Logs : (the new native logger)
Validation
npx eslint src/**/*.tspassesdebug,info,warn,error,setLevel) remains available