Skip to content

fix(build): move linux desktop MimeType into entry for electron-builder 26 schema#3347

Merged
jeanfbrito merged 1 commit into
masterfrom
fix-linux-desktop-mimetype
May 27, 2026
Merged

fix(build): move linux desktop MimeType into entry for electron-builder 26 schema#3347
jeanfbrito merged 1 commit into
masterfrom
fix-linux-desktop-mimetype

Conversation

@jeanfbrito
Copy link
Copy Markdown
Member

@jeanfbrito jeanfbrito commented May 27, 2026

Summary

Fixes a Linux build failure caused by an invalid electron-builder configuration.

electron-builder 26 tightened its schema for linux.desktop, which now accepts only { desktopActions?, entry? }. The MimeType key — added alongside the telephony deep-linking feature — was placed directly under linux.desktop, so 26.0.3's stricter validation rejects it and aborts the build:

⨯ Invalid configuration object. electron-builder 26.0.3 has been initialized using a
  configuration object that does not match the API schema.
 - configuration.linux.desktop has an unknown property 'MimeType'. These properties are valid:
   object { desktopActions?, entry? }

Change

Moved MimeType into linux.desktop.entry, where freedesktop desktop-entry keys belong. The generated .desktop file is unchanged — MimeType still lands in the desktop entry, registering the rocketchat:, callto:, and tel: scheme handlers as before.

Verification

  • electron-builder config validation passes locally (the schema error is gone).
  • Diff is a single two-line move in electron-builder.json; no behavioral change to the produced artifact.

Summary by CodeRabbit

  • Improvements
    • Enhanced Linux desktop integration with support for additional URL scheme handlers, including rocketchat, callto, and tel protocols.

Review Change Stack

…er 26 schema

electron-builder 26 restricts linux.desktop to { desktopActions, entry }.
The MimeType key (added with telephony deep-linking) sat at desktop.MimeType,
which 26.0.3's stricter validation rejects, failing the build step on Linux.
Moved it into desktop.entry where freedesktop desktop-entry keys belong.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f87126eb-4099-4726-ab00-f1a8fd698b1a

📥 Commits

Reviewing files that changed from the base of the PR and between bd8830e and a1fd5dc.

📒 Files selected for processing (1)
  • electron-builder.json

Walkthrough

Updated the Linux desktop entry configuration in electron-builder.json to register MIME type mappings for three URL scheme handlers: rocketchat, callto, and tel. These entries enable the application to handle incoming URI requests for these protocols on Linux systems.

Changes

URL Scheme Handler MIME Types

Layer / File(s) Summary
MIME type registration for URL scheme handlers
electron-builder.json
Added MimeType entries for x-scheme-handler/rocketchat, x-scheme-handler/callto, and x-scheme-handler/tel in the Linux desktop entry configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

type: chore


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jeanfbrito jeanfbrito merged commit 3c89e81 into master May 27, 2026
8 of 9 checks passed
@jeanfbrito jeanfbrito deleted the fix-linux-desktop-mimetype branch May 27, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant