fix(build): move linux desktop MimeType into entry for electron-builder 26 schema#3347
Merged
Conversation
…er 26 schema
electron-builder 26 restricts linux.desktop to { desktopActions, entry }.
The MimeType key (added with telephony deep-linking) sat at desktop.MimeType,
which 26.0.3's stricter validation rejects, failing the build step on Linux.
Moved it into desktop.entry where freedesktop desktop-entry keys belong.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughUpdated the Linux desktop entry configuration in ChangesURL Scheme Handler MIME Types
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Linux build failure caused by an invalid
electron-builderconfiguration.electron-builder26 tightened its schema forlinux.desktop, which now accepts only{ desktopActions?, entry? }. TheMimeTypekey — added alongside the telephony deep-linking feature — was placed directly underlinux.desktop, so 26.0.3's stricter validation rejects it and aborts the build:Change
Moved
MimeTypeintolinux.desktop.entry, where freedesktop desktop-entry keys belong. The generated.desktopfile is unchanged —MimeTypestill lands in the desktop entry, registering therocketchat:,callto:, andtel:scheme handlers as before.Verification
electron-builderconfig validation passes locally (the schema error is gone).electron-builder.json; no behavioral change to the produced artifact.Summary by CodeRabbit