Feature/typescript v6 by H-Weisner · Pull Request #287 · Rocketmakers/armstrong-edge

H-Weisner · 2026-04-01T15:57:37Z

What's new?

This pull request updates the project's TypeScript tooling and related dependencies to use TypeScript 6.0.2, along with an upgrade of ts-jest to 29.4.9. The changes affect both package.json and the pnpm-lock.yaml lockfile, ensuring all dependencies and peer dependencies are aligned with the new TypeScript version.

Dependency upgrades:

Upgraded typescript from 5.1.6 to 6.0.2 in both package.json and pnpm-lock.yaml, updating all related references and peer dependencies throughout the lockfile. [1] [2] [3] [4] [5]
Upgraded ts-jest from 29.1.1 to 29.4.9, including its peer dependencies and compatibility with TypeScript 6.0.2. [1] [2] [3]

Lockfile consistency:

Updated all dependencies, peer dependencies, and transitive dependencies in pnpm-lock.yaml to use TypeScript 6.0.2, ensuring consistency across the toolchain (including ESLint, Storybook, semantic-release, and related plugins). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

These updates ensure the project uses the latest TypeScript features and maintains compatibility with the ecosystem.

Ticket number(s) in JIRA (if internal)

ARM-XX

board

Checklist

[✓] does this work have all the relevant tests?
[✓] are your changes in Storybook?
[✓] does everything have jsdoc?
[✓] is everything exported from index.ts?

Upgrades TypeScript from 5.1.6 to 6.0.2 and ts-jest from 29.1.1 to 29.4.9 to align the build toolchain with the TypeScript 6 release. The ts-jest upgrade was required because 29.1.1 enforced a `typescript < 6` peer dependency constraint; 29.4.9 relaxes this to `< 7`. Lockfiles for both module and storybook workspaces are updated accordingly. BREAKING CHANGE: consumers using TypeScript < 6 may encounter type incompatibilities if emitted declaration files rely on TypeScript 6 type semantics

Adds @types/node to provide TypeScript type definitions for Node.js built-in modules. This ensures correct typings are available for Node APIs used during build and tooling scripts.

# Conflicts: # module/package.json # module/pnpm-lock.yaml # storybook/package.json # storybook/pnpm-lock.yaml

Updates `import React from 'react'` to `import * as React from 'react'` across select component, useChildForm hook, and useSSRLayoutEffect spec. This aligns with the TypeScript ESM-compatible import style required for the TypeScript v6 upgrade, where default imports from React may not resolve correctly under stricter module resolution settings.

Copilot

Pull request overview

Updates the repo’s TypeScript toolchain to TypeScript 6.0.2 (and ts-jest 29.4.9 in module/), with accompanying lockfile refreshes and TS config tweaks to align with bundler-style module resolution.

Changes:

Bump TypeScript to 6.0.2 in module/ and storybook/ package manifests and lockfiles.
Upgrade ts-jest to 29.4.9 in module/ and update the lockfile dependency graph accordingly.
Adjust module/ TypeScript configuration (notably moduleResolution: "bundler" and removal of interop flags).

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
storybook/pnpm-lock.yaml	Refresh Storybook lockfile to reflect TypeScript 6.0.2 throughout resolved dependency snapshots.
storybook/package.json	Bump Storybook workspace TypeScript dependency to 6.0.2.
module/tsconfig.node.json	Switch node tsconfig to bundler resolution and remove synthetic default import setting.
module/tsconfig.json	Remove several compiler options (including interop-related ones) and keep bundler module resolution.
module/pnpm-lock.yaml	Refresh module lockfile for TypeScript 6.0.2 + ts-jest 29.4.9; update peer/optional deps snapshots.
module/package.json	Bump `typescript` to 6.0.2 and `ts-jest` to 29.4.9.

Files not reviewed (2)

module/pnpm-lock.yaml: Language not supported
storybook/pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T12:54:29Z

-    "preserveConstEnums": false,
    "module": "ESNext",
    "moduleResolution": "bundler",
    "resolveJsonModule": true,


module/tsconfig.json removes esModuleInterop / allowSyntheticDefaultImports, but the codebase contains default imports from CommonJS-style modules (e.g. multiple import React from 'react' usages). With these flags removed, TypeScript will typically error on those imports. Either restore one of these interop options (preferred if you want to keep default-import style), or update the affected imports to namespace imports (e.g. import * as React from 'react') consistently across the module.

Suggested change

"resolveJsonModule": true,

"resolveJsonModule": true,

"esModuleInterop": true,

Copilot · 2026-04-07T12:54:30Z

    "module": "ESNext",
-    "moduleResolution": "Node",
-    "allowSyntheticDefaultImports": true
+    "moduleResolution": "bundler"


module/tsconfig.node.json drops allowSyntheticDefaultImports, but vite.config.ts uses default imports like import path from 'path'. Without allowSyntheticDefaultImports or esModuleInterop, this commonly fails type-checking in TS. Consider re-adding the interop option for the node tsconfig, or change the imports in vite.config.ts to namespace imports.

Suggested change

"moduleResolution": "bundler"

"moduleResolution": "bundler",

"allowSyntheticDefaultImports": true

Copilot · 2026-04-07T12:54:30Z

      - supports-color

  typescript@5.8.2: {}

-  typescript@5.9.3: {}
+  typescript@6.0.2: {}


The PR description says the lockfile has been updated so transitive dependencies use TypeScript 6.0.2 for toolchain consistency, but pnpm-lock.yaml still includes typescript@5.8.2 (pulled in via @microsoft/api-extractor). If this is intentional, the description should be adjusted; otherwise consider upgrading the relevant tooling so it can depend on TypeScript 6 to avoid multiple compiler versions in the install.

Converts all `import * as React from 'react'` statements to `import React from 'react'` across components, hooks, form, and type files. Also disables the `import-x/default` ESLint rule and enables `esModuleInterop`-compatible resolution in tsconfig to support the new import style. This aligns with React 19 conventions and the ongoing TypeScript v6 upgrade.

…t line Merges separate named type imports (HTMLInputTypeAttribute, LabelHTMLAttributes, act) onto the same line as the default React import across components and tests. Reduces import verbosity and aligns with idiomatic TypeScript import style.

Copilot

Pull request overview

Copilot reviewed 70 out of 72 changed files in this pull request and generated 3 comments.

Files not reviewed (2)

module/pnpm-lock.yaml: Language not supported
storybook/pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T13:49:29Z

+import React from 'react';
 import { LabelHTMLAttributes } from 'react';


There are two separate imports from 'react' in this file (a default import plus a named import), which will violate the configured import-x/no-duplicates rule. Combine them into a single import (and consider marking LabelHTMLAttributes as type-only) to satisfy the linter.

Suggested change

import React from 'react';

import { LabelHTMLAttributes } from 'react';

import React, { type LabelHTMLAttributes } from 'react';

Copilot · 2026-04-07T13:49:30Z

+import React from 'react';
 import { HTMLInputTypeAttribute } from 'react';


This file now imports from 'react' twice (import React ... and a separate named import). With import-x/no-duplicates enabled, this will fail linting. Please merge these into a single import (and make HTMLInputTypeAttribute type-only if applicable).

Suggested change

import React from 'react';

import { HTMLInputTypeAttribute } from 'react';

import React, { type HTMLInputTypeAttribute } from 'react';

Copilot · 2026-04-07T13:49:30Z

+import React from 'react';
 import { act } from 'react';


There are two imports from 'react' here (import React ... and import { act } ...), which will trip import-x/no-duplicates. Merge into a single import from 'react' to keep lint passing.

H-Weisner requested review from adamiprinciples and Copilot and removed request for Copilot April 1, 2026 18:16

H-Weisner added 4 commits April 1, 2026 19:33

chore(deps): Add @types/node dev dependency

daacd3c

Adds @types/node to provide TypeScript type definitions for Node.js built-in modules. This ensures correct typings are available for Node APIs used during build and tooling scripts.

Merge branch 'feature/react-19' into feature/typescript-v6

9758764

Merge branch 'main' into feature/typescript-v6

ff4e081

# Conflicts: # module/package.json # module/pnpm-lock.yaml # storybook/package.json # storybook/pnpm-lock.yaml

Merge remote-tracking branch 'origin/main' into feature/typescript-v6

8e31958

H-Weisner requested a review from Copilot April 7, 2026 12:49

Copilot started reviewing on behalf of H-Weisner April 7, 2026 12:50 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

H-Weisner added 2 commits April 7, 2026 14:05

Merge branch 'main' into feature/typescript-v6

854a759

H-Weisner requested a review from Copilot April 7, 2026 13:42

Copilot started reviewing on behalf of H-Weisner April 7, 2026 13:43 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

H-Weisner merged commit d3d935b into main Apr 7, 2026
8 of 10 checks passed

H-Weisner deleted the feature/typescript-v6 branch April 7, 2026 13:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/typescript v6#287

Feature/typescript v6#287
H-Weisner merged 9 commits into
mainfrom
feature/typescript-v6

H-Weisner commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	"resolveJsonModule": true,
	"resolveJsonModule": true,
	"esModuleInterop": true,

	"moduleResolution": "bundler"
	"moduleResolution": "bundler",
	"allowSyntheticDefaultImports": true

		import React from 'react';
		import { LabelHTMLAttributes } from 'react';

	import React from 'react';
	import { LabelHTMLAttributes } from 'react';
	import React, { type LabelHTMLAttributes } from 'react';

		import React from 'react';
		import { HTMLInputTypeAttribute } from 'react';

	import React from 'react';
	import { HTMLInputTypeAttribute } from 'react';
	import React, { type HTMLInputTypeAttribute } from 'react';

Conversation

H-Weisner commented Apr 1, 2026

What's new?

Ticket number(s) in JIRA (if internal)

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants