Fix config merge order to respect user config when input signals are undefined #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #1: input signals were falling back to hardcoded defaults instead of user-provided config values when undefined.
Change
Modified the config merge in
NgxMarkdownEditorComponentconstructor to:DEFAULT_EDITOR_CONFIGwith userconfig()intobaseConfigbaseConfigas fallback instead of hardcoded valuesBefore:
After:
This ensures precedence: defaults < user config < explicit input signals.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.