Updated command line tool to operate with OpenCV4#4
Open
ch00f wants to merge 5 commits intoRoelofBerg:masterfrom
Open
Updated command line tool to operate with OpenCV4#4ch00f wants to merge 5 commits intoRoelofBerg:masterfrom
ch00f wants to merge 5 commits intoRoelofBerg:masterfrom
Conversation
…the version, just that opencv4 is installed
Owner
|
Hi,I suggest to drop the limereg package, in case that it might not be installed frequently by any users.I have, unfortunately, no further information that could help here with the package check.Thanks for updating the code.Best Regards Roelof(Original author)Von meinem Mobiltelefon gesendet.Am 03.01.2024 um 21:13 schrieb Michael Ciuffo ***@***.***>:The command line tool uses the C version of OpenCV which I understand has been deprecated for some time, so I updated all the references to work in the C++ version of OpenCV4.
I wasn't sure how to fix the package check. I set the check to look for 4.5.4 which is what I have installed and have tested, but it appears to pass no matter what version is specified, as long as it's opencv4.
This is my first ever contribution to anything open source, so be gentle!
You can view, comment on, or merge this pull request online at:
#4
Commit Summary
d989de7 Added some lines to install instructions to fix errors I ran into when installing
fd5756a chipping away at getting opencv CPP support working
b47032a finished updates so it compiles and installs. Let's see if it works!
4ae992f Fixed bug mappin x and y backwards
84b1c84 updated opencv version check though I don't think it actually checks the version, just that opencv4 is installed
File Changes (6 files)
M
INSTALL
(320)
M
README
(3)
M
configure.ac
(8)
M
exe/CRegistrationController.cpp
(90)
M
exe/CRegistrationController.h
(6)
M
exe/stdafx.h
(6)
Patch Links:
https://github.com/RoelofBerg/limereg/pull/4.patch
https://github.com/RoelofBerg/limereg/pull/4.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command line tool uses the C version of OpenCV which I understand has been deprecated for some time, so I updated all the references to work in the C++ version of OpenCV4.
I wasn't sure how to fix the package check. I set the check to look for 4.5.4 which is what I have installed and have tested, but it appears to pass no matter what version is specified, as long as it's opencv4.
This is my first ever contribution to anything open source, so be gentle!