Reconfigure xarray update#1
Open
jameshalgren wants to merge 3 commits intoRohanSunkarapalli:updated_xarray_methodsfrom
Open
Reconfigure xarray update#1jameshalgren wants to merge 3 commits intoRohanSunkarapalli:updated_xarray_methodsfrom
jameshalgren wants to merge 3 commits intoRohanSunkarapalli:updated_xarray_methodsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update rebases the changes from updated_xarray_methods onto the latest changes from the ngen_forcing branch in the upstream.
The upstream changes include some of the updates from the former, so the merge is a bit messy, unfortunately.
Git modifications to the updated_xarray_methods include removing indexing anomalies (
j+=1), using only the index and feature list of the geopackage instead of the full object (which may not have yielded significant benefits) and an attempt to use similar syntax for forming the dictionaries in each of the functions. It would be helpful to include a separate helper function to perform the translation.NOTE: in the process of examining this pull request which is the root of the updated_xarray_methods branch, we noticed that the parallel methods only work when the raster engine is not set to
rasterio... BUT then the calculation doesn't produce the right answer. So... another bug to track down. It may not be possible to do this in parallel.