Skip to content

Switch to trusted publishing and align CI workflows with ya-disk - #343

Merged
RomiC merged 1 commit into
mainfrom
chore/trusted-publishing
Aug 8, 2026
Merged

Switch to trusted publishing and align CI workflows with ya-disk#343
RomiC merged 1 commit into
mainfrom
chore/trusted-publishing

Conversation

@RomiC

@RomiC RomiC commented Aug 8, 2026

Copy link
Copy Markdown
Owner

What changed

  • Trusted publishing: replaced NPM_TOKEN secret with OIDC (id-token: write)
  • Pinned actions to exact versions (checkout@v7.0.1, setup-node@v7.0.0)
  • Test workflow: fixed branch trigger mastermain, added permissions
  • Both workflows: added npm run lint, npm run format:check, and npm run build to CI pipeline

Remaining manual step

After merge, add RomiC/ya-disk-stream as a Trusted Publisher on npmjs.com (package settings → Access → Trusted Publishers).

@coveralls

coveralls commented Aug 8, 2026

Copy link
Copy Markdown

Coverage Status

Coverage is 100.0%chore/trusted-publishing into main. No base build found for main.

@greptile-apps

greptile-apps Bot commented Aug 8, 2026

Copy link
Copy Markdown

Greptile Summary

This PR switches npm publication from a repository token to OIDC trusted publishing and aligns the test and release workflows with the main branch and expanded validation.

  • Grants the publishing job permission to request an OIDC token and removes NPM_TOKEN usage.
  • Updates GitHub Action references to exact semantic versions.
  • Adds formatting, linting, and build checks to the CI workflows.
  • Corrects the test workflow’s push trigger from master to main.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/npm-publish.yml Adds restricted workflow permissions, OIDC-based npm publishing, exact action versions, and lint/format validation before release.
.github/workflows/npm-test.yml Corrects the tested branch, updates action versions, and adds formatting and build validation to the test matrix.

Reviews (2): Last reviewed commit: "Chore: Switch to trusted publishing and ..." | Re-trigger Greptile

- Replaced NPM_TOKEN with OIDC trusted publishing (id-token: write)
- Pinned GitHub Actions to exact versions
- Fixed branch trigger from master to main
- Added lint, format, and build checks to CI pipeline
@RomiC
RomiC force-pushed the chore/trusted-publishing branch from 613e261 to 028b273 Compare August 8, 2026 15:07
@RomiC RomiC self-assigned this Aug 8, 2026
@RomiC RomiC added bug dx Changes relative to the Developer eXperience labels Aug 8, 2026
@RomiC
RomiC merged commit 3876d4b into main Aug 8, 2026
8 checks passed
@RomiC
RomiC deleted the chore/trusted-publishing branch August 8, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug dx Changes relative to the Developer eXperience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants