Chore: [#150] Migrate from ESLint and Prettier to Oxlint and Oxfmt - #158
Merged
Conversation
Greptile SummaryThe PR replaces ESLint and Prettier with Oxlint and Oxfmt and updates automation to use the new commands.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| package.json | Defines matching Oxlint and Oxfmt scripts, dependencies, and lint-staged commands. |
| .github/workflows/npm-test.yml | Replaces the removed aggregate lint command with existing lint and formatting-check scripts. |
| .github/workflows/npm-publish.yml | Runs the new lint and formatting checks before testing and publication. |
| oxlint.config.mjs | Introduces the Oxlint correctness and Node environment configuration. |
| oxfmt.config.mjs | Introduces formatting settings corresponding to the previous project style. |
| specs/cli.spec.js | Rewrites test conditionals to satisfy the new lint rules without changing their intended branches. |
Reviews (2): Last reviewed commit: "Chore: [#150] Migrate from ESLint and Pr..." | Re-trigger Greptile
Comment on lines
+11
to
+14
| "lint": "oxlint -c oxlint.config.mjs", | ||
| "lint:fix": "oxlint -c oxlint.config.mjs --fix", | ||
| "format": "oxfmt -c oxfmt.config.mjs", | ||
| "format:check": "oxfmt -c oxfmt.config.mjs --check", |
There was a problem hiding this comment.
When either GitHub Actions workflow runs, it still invokes npm run lint:all, but this scripts block no longer defines that command, causing the test and publish pipelines to terminate with npm's missing-script error.
Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 11-14
Comment:
**Removed script breaks CI**
When either GitHub Actions workflow runs, it still invokes `npm run lint:all`, but this scripts block no longer defines that command, causing the test and publish pipelines to terminate with npm's missing-script error.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.- Replace eslint, @eslint/js, @eslint/markdown, eslint-config-prettier, eslint-plugin-prettier, globals and prettier devDependencies with oxlint and oxfmt - Delete eslint.config.js and .prettierrc - Add oxlint.config.mjs and oxfmt.config.mjs - Update lint scripts and lint-staged to use oxlint and oxfmt - Fix ternary-as-statement patterns in specs to satisfy oxlint correctness rules
RomiC
force-pushed
the
feature/150-oxlint-migration
branch
from
August 8, 2026 17:28
6c3b94e to
8044e83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #150
Replace ESLint + Prettier with Oxlint + Oxfmt, matching the ya-disk and ya-disk-stream project setup.
Changes