Skip to content

Chore: [#150] Migrate from ESLint and Prettier to Oxlint and Oxfmt - #158

Merged
RomiC merged 1 commit into
mainfrom
feature/150-oxlint-migration
Aug 8, 2026
Merged

Chore: [#150] Migrate from ESLint and Prettier to Oxlint and Oxfmt#158
RomiC merged 1 commit into
mainfrom
feature/150-oxlint-migration

Conversation

@RomiC

@RomiC RomiC commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Closes #150

Replace ESLint + Prettier with Oxlint + Oxfmt, matching the ya-disk and ya-disk-stream project setup.

Changes

  • Remove eslint, @eslint/js, @eslint/markdown, eslint-config-prettier, eslint-plugin-prettier, globals and prettier
  • Add oxlint 1.77.0 and oxfmt 0.62.0
  • Add oxlint.config.mjs and oxfmt.config.mjs
  • Delete eslint.config.js and .prettierrc
  • Update lint-staged to run oxlint --fix + oxfmt on staged files
  • Add format and format:check scripts
  • Fix ternary-as-statement patterns in specs to satisfy oxlint correctness rules

@greptile-apps

greptile-apps Bot commented Aug 8, 2026

Copy link
Copy Markdown

Greptile Summary

The PR replaces ESLint and Prettier with Oxlint and Oxfmt and updates automation to use the new commands.

  • Adds Oxlint and Oxfmt dependencies and configuration.
  • Splits CI linting and formatting checks into matching package scripts.
  • Updates staged-file processing and reformats affected files.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
package.json Defines matching Oxlint and Oxfmt scripts, dependencies, and lint-staged commands.
.github/workflows/npm-test.yml Replaces the removed aggregate lint command with existing lint and formatting-check scripts.
.github/workflows/npm-publish.yml Runs the new lint and formatting checks before testing and publication.
oxlint.config.mjs Introduces the Oxlint correctness and Node environment configuration.
oxfmt.config.mjs Introduces formatting settings corresponding to the previous project style.
specs/cli.spec.js Rewrites test conditionals to satisfy the new lint rules without changing their intended branches.

Reviews (2): Last reviewed commit: "Chore: [#150] Migrate from ESLint and Pr..." | Re-trigger Greptile

Comment thread package.json
Comment on lines +11 to +14
"lint": "oxlint -c oxlint.config.mjs",
"lint:fix": "oxlint -c oxlint.config.mjs --fix",
"format": "oxfmt -c oxfmt.config.mjs",
"format:check": "oxfmt -c oxfmt.config.mjs --check",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Removed script breaks CI

When either GitHub Actions workflow runs, it still invokes npm run lint:all, but this scripts block no longer defines that command, causing the test and publish pipelines to terminate with npm's missing-script error.

Prompt To Fix With AI
This is a comment left during a code review.
Path: package.json
Line: 11-14

Comment:
**Removed script breaks CI**

When either GitHub Actions workflow runs, it still invokes `npm run lint:all`, but this scripts block no longer defines that command, causing the test and publish pipelines to terminate with npm's missing-script error.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

- Replace eslint, @eslint/js, @eslint/markdown, eslint-config-prettier, eslint-plugin-prettier, globals and prettier devDependencies with oxlint and oxfmt
- Delete eslint.config.js and .prettierrc
- Add oxlint.config.mjs and oxfmt.config.mjs
- Update lint scripts and lint-staged to use oxlint and oxfmt
- Fix ternary-as-statement patterns in specs to satisfy oxlint correctness rules
@RomiC
RomiC force-pushed the feature/150-oxlint-migration branch from 6c3b94e to 8044e83 Compare August 8, 2026 17:28
@RomiC RomiC self-assigned this Aug 8, 2026
@RomiC RomiC added dependencies Related to dependencies update dx Changes relative to the Developer eXperience labels Aug 8, 2026
@RomiC
RomiC merged commit e9113d8 into main Aug 8, 2026
6 of 10 checks passed
@RomiC
RomiC deleted the feature/150-oxlint-migration branch August 8, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related to dependencies update dx Changes relative to the Developer eXperience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from ESLint to Oxlint

1 participant