Skip to content

Reuse rendered compose for image verification - #444

Merged
RonaldHensbergen merged 1 commit into
RonaldHensbergen:mainfrom
SemTiOne:fix/double-render-cleanup
Aug 17, 2026
Merged

Reuse rendered compose for image verification#444
RonaldHensbergen merged 1 commit into
RonaldHensbergen:mainfrom
SemTiOne:fix/double-render-cleanup

Conversation

@SemTiOne

Copy link
Copy Markdown
Collaborator

Pull Request

Summary

cds security --verify-images plans and renders the profile twice. This change renders once and shares the compose with image verification via PrecomputedRender and new optional params on _run_image_verification. Also replaces private symbol imports (_infer_profile_class, _SEVERITY_ORDER) with public ones from cli.security_common.

Fixes #336

Type Of Change

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Test only

User Impact

cds security --verify-images no longer repeats plan/render. Faster scans on large profiles.

Validation

python -m unittest discover -s tests -p "test_*.py" -v # All tests passed

Checklist

  • Tests added or updated
  • Docs updated (README or docs)
  • No secrets committed
  • Generated artifacts excluded from git

@SemTiOne
SemTiOne force-pushed the fix/double-render-cleanup branch from 60dabb5 to 2d33f36 Compare August 17, 2026 09:35
@SemTiOne

Copy link
Copy Markdown
Collaborator Author

@RonaldHensbergen This LGTM.

@RonaldHensbergen
RonaldHensbergen merged commit a802f7d into RonaldHensbergen:main Aug 17, 2026
11 checks passed
@SemTiOne
SemTiOne deleted the fix/double-render-cleanup branch August 17, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double profile render in --verify-images, private symbol imports, and follow-ups from #330 review

2 participants