Skip to content

Remove OPC DA client and server implementations and related dependencies#22

Merged
Ronbb merged 4 commits intomasterfrom
feat/opc_da
Jul 24, 2025
Merged

Remove OPC DA client and server implementations and related dependencies#22
Ronbb merged 4 commits intomasterfrom
feat/opc_da

Conversation

@Ronbb
Copy link
Owner

@Ronbb Ronbb commented Jul 24, 2025

Summary by CodeRabbit

  • Chores

    • Removed numerous dependencies and features related to OPC DA client and server functionality.
    • Eliminated support for various OPC DA versions and related utilities.
    • Cleaned up build scripts and dependency declarations for improved maintainability.
  • Refactor

    • Removed all public interfaces, modules, and utilities associated with OPC DA client and server operations, including COM interop, memory management, and trait abstractions.
  • Bug Fixes

    • Adjusted build scripts to prevent unnecessary code generation steps.

End-users will no longer have access to OPC DA client/server features or related utilities in this release.

Ronbb added 3 commits July 18, 2025 16:25
- Update Cargo.toml workspace dependencies
- Clean up build.rs files in binding crates
- Update Cargo.lock with latest dependency versions
@coderabbitai
Copy link

coderabbitai bot commented Jul 24, 2025

Walkthrough

This change removes the entire OPC DA client and server implementation, including all associated traits, modules, utilities, and data structures. It also eliminates related dependencies from the workspace and crate manifests, and updates build scripts to remove the --implement flag for code generation. All OPC DA-related Rust code, COM interface wrappers, and utilities are deleted.

Changes

File(s) / Path(s) Change Summary
Cargo.toml, opc_ae_bindings/Cargo.toml, .../Cargo.toml Removed dependencies: actix, globset, tokio, windows-targets; added/updated path dependencies and thiserror.
opc_ae_bindings/build.rs, opc_comn_bindings/build.rs, ... Removed --implement flag from windows_bindgen code generation in build scripts.
opc_da/Cargo.toml Removed actix, globset, tokio dependencies; added thiserror; removed all feature flags.
opc_da/src/lib.rs, opc_da/src/def.rs, ... Deleted all OPC DA client/server modules, traits, data structures, and utilities.
opc_da/src/client/, opc_da/src/server/, ... Removed all code for OPC DA client and server implementations, including unified interfaces and COM wrappers.
opc_da/src/utils/* Deleted all memory, native type, and iterator utilities for OPC DA.
opc_da_bindings/Cargo.toml, opc_hda_bindings/Cargo.toml Removed windows-targets dependency from bindings crates.
opc_da_bindings/build.rs, opc_hda_bindings/build.rs Removed --implement flag from bindings build scripts.

Sequence Diagram(s)

Omitted: The changes are wholesale deletions and dependency updates, with no remaining control flow or feature to illustrate.

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~90+ minutes

Complexity: This is a critical and high-complexity change, involving the complete removal of a large subsystem (OPC DA client/server), all associated traits, data structures, utilities, and workspace dependency updates. It spans numerous files and eliminates core functionality, requiring comprehensive review to ensure nothing remains and all dependencies are correctly updated.

Possibly related PRs

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/opc_da

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

- Remove windows-targets from workspace dependencies
- Remove windows-targets from all binding crates
- Clean up Cargo.lock to reflect dependency removal
@coderabbitai coderabbitai bot changed the title @coderabbitai Remove OPC DA client and server implementations and related dependencies Jul 24, 2025
@Ronbb Ronbb marked this pull request as ready for review July 24, 2025 06:39
@Ronbb Ronbb merged commit e4f25e1 into master Jul 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant