Skip to content

Fix Side Margins for Mobile#40

Merged
Kokonutic merged 1 commit intomainfrom
topic/20260111
Jan 12, 2026
Merged

Fix Side Margins for Mobile#40
Kokonutic merged 1 commit intomainfrom
topic/20260111

Conversation

@Kokonutic
Copy link
Copy Markdown
Collaborator

@Kokonutic Kokonutic commented Jan 12, 2026

This PR fixes the side margins to allow content to be properly displayed on mobile screens. This regression was caused by #38

Changes:

  • Implements mobile-first responsive padding for article.x:container using media queries
  • Scales padding from 1rem on mobile to 10rem on large desktop screens
  • Uses standard responsive breakpoints (768px, 1024px, 1280px)

PR CHECKLIST

  • My code follows the style guidelines of this project (variable naming, commenting, copyright, etc.)
  • I have performed a self-review of my code
  • Changes are clearly highlighted and easy to understand
  • I have commented my code, particularly in hard-to-understand areas
  • I have meaningful commit messages that explain what was changed/committed
  • I have built and locally tested my changes
  • My changes generate no new errors or regressions (pending verification)
  • I have made corresponding changes to the documentation OR this is N/A
  • Documentation accurately reflects the current state of the project OR this is N/A
  • I have added tests that prove my fix is effective or that my feature works OR this is N/A
  • New and existing unit tests pass locally with my changes OR this is N/A
  • Any dependent changes have been merged and published in downstream modules OR this is N/A
  • All links are working and correct OR this is N/A
  • Spelling and grammar are correct
  • I have added the "READY FOR REVIEWS" tag when this PR is ready for reviews

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a mobile responsiveness regression by replacing fixed 10rem side padding with a responsive padding system that adapts to different screen sizes. The previous PR #38 had introduced fixed padding that was too large for mobile devices, preventing proper content display.

Changes:

  • Implements mobile-first responsive padding for article.x\:container using media queries
  • Scales padding from 1rem on mobile to 10rem on large desktop screens
  • Uses standard responsive breakpoints (768px, 1024px, 1280px)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Owner

@Rongbin99 Rongbin99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via Network and regression is fixed.

@Kokonutic Kokonutic merged commit fe92971 into main Jan 12, 2026
8 checks passed
@Kokonutic Kokonutic deleted the topic/20260111 branch January 12, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants