[Fix] Slack tasks post duplicate kickoff messages - #1424
Merged
mrubens merged 10 commits intoAug 17, 2026
Conversation
Contributor
|
No code issues found. See task
Reviewed d6beb2b |
Contributor
Author
|
Added incremental Fast-parent artifact relay in |
- Serialize Fast turns behind a shared turn lock with a cappable wait - Lease-based delivery claims: crashed deliveries are stealable, in-flight ones report 503 instead of a false already_delivered success - Release delivery claims only when Slack was never posted; stamp event posts with a deterministic client_msg_id to prevent duplicate replies - Rethrow platform-event turn errors so notifiers can retry instead of recording failed deliveries as delivered - Deliver the parent-owned kickoff post-enqueue for launchers without a kickoff hook (Discord parity) - Route structured request_user_input answers to Fast children and start their Slack answer polling - Treat deleted-source reply suppression as handled, not a turn failure - Detach the parent settle notification from the settle hot path
A deleted trigger message suppresses the kickoff post without anything visible or durable, so treating it as success let the child become runnable with no parent-owned kickoff. Suppression now fails the launch gate while remaining a quiet success for ordinary replies.
mrubens
marked this pull request as ready for review
August 17, 2026 05:36
mrubens
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
August 17, 2026 05:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
parentOwnsKickoffmechanism.Why this change was made
Fast delegation previously gave both parent and child authority to narrate the same Slack lifecycle. Suppressing only the child's first acknowledgement still left Slack capabilities available, introduced a race before the parent kickoff was delivered, lost isolation on snapshot resume, and left child artifacts visible only inside the task.
Impact
The Fast parent is now the sole owner of Slack-visible kickoff, lifecycle, and artifact updates. Fast children cannot read or post chat messages directly, including after snapshot resume, and they are not made runnable until the parent kickoff is durable. Each published artifact version appears promptly in the originating Slack thread without waiting for settlement. Independently launched non-Fast Slack tasks and artifact uploads retain their existing behavior.
Related PRs