Skip to content

[Fix] Request Agent scope during Slack installs - #1426

Merged
mrubens merged 1 commit into
developfrom
codex/slack-oauth-agent-scope
Aug 17, 2026
Merged

[Fix] Request Agent scope during Slack installs#1426
mrubens merged 1 commit into
developfrom
codex/slack-oauth-agent-scope

Conversation

@mrubens

@mrubens mrubens commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Related issue

Internal Roomote work; no linked issue.

Why this PR exists

  • I am a maintainer / this is internal Roomote work

The generated Slack app manifest and the OAuth installer maintained separate hard-coded bot-scope lists. After Agent messaging added assistant:write to the manifest, the install URL continued requesting the older list, so newly installed bot tokens did not receive the Agent scope.

What changed

  • build Slack installation URLs from the manifest's canonical bot scopes
  • remove the duplicated scope list from the Slack connection command
  • add regression coverage proving OAuth installs request assistant:write

Impact

Generated Slack apps now receive the same scopes during OAuth installation that their manifests declare, enabling Slack's Agent messaging APIs after reinstalling the app.

How it was tested

  • Slack install URL and manifest client tests (10 passed)
  • @roomote/web typecheck
  • targeted ESLint
  • focused formatting check

Checklist

  • The PR title follows the repo convention
  • This PR is small and scoped to one change
  • Focused lint and typecheck pass locally
  • I added tests and included validation notes above
  • I removed secrets, tokens, private keys, and customer data
  • Changelog entry (not included in this scoped fix)

@roomote-community

roomote-community Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 6da1cd7

@mrubens
mrubens marked this pull request as ready for review August 17, 2026 02:54
@mrubens
mrubens merged commit b2ee86a into develop Aug 17, 2026
17 checks passed
@mrubens
mrubens deleted the codex/slack-oauth-agent-scope branch August 17, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant