Skip to content

[Fix] Terminal views flood browser error telemetry #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
roomote-roomote wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

[Fix] Terminal views flood browser error telemetry #1430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 134 additions & 0 deletions apps/web/src/app/(sandbox)/task/[taskId]/hooks/__tests__/use-terminal.client.test.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

23 changes: 20 additions & 3 deletions apps/web/src/app/(sandbox)/task/[taskId]/hooks/use-terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export function useTerminal(
let opened = false;
let intentionalClose = false;
let initialInputSent = false;
let resizeFrame: number | null = null;

// Helper to fit the terminal and notify the server of the new size.
function fitAndResize() {
Expand Down Expand Up @@ -212,7 +213,6 @@ export function useTerminal(

opened = true;
terminal.open(container);
fitAddon.fit();
connect();
}

Expand All @@ -231,8 +231,22 @@ export function useTerminal(

// Resize handling — also triggers deferred open when container becomes visible.
const resizeObserver = new ResizeObserver(() => {
openIfReady();
fitAndResize();
if (resizeFrame !== null) {
return;
}

// Fitting xterm mutates layout. Defer it outside the ResizeObserver
// callback and coalesce notifications to avoid observer feedback loops.
resizeFrame = requestAnimationFrame(() => {
resizeFrame = null;

if (!opened) {
openIfReady();
return;
}

fitAndResize();
});
});
resizeObserver.observe(container);

Expand All @@ -241,6 +255,9 @@ export function useTerminal(
intentionalClose = true;
connectRef.current = null;
cancelAnimationFrame(initialOpenFrame);
if (resizeFrame !== null) {
cancelAnimationFrame(resizeFrame);
}

resizeObserver.disconnect();
inputDisposable.dispose();
Expand Down
1 change: 1 addition & 0 deletions apps/web/src/components/layout/CloudAnalyticsProvider.client.test.tsx
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions apps/web/src/components/layout/CloudAnalyticsProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const DEFAULT_POSTHOG_HOST = 'https://us.i.posthog.com';
type PostHogOptions = {
api_host: string;
defaults: '2026-05-30';
capture_exceptions: boolean;
disable_session_recording: boolean;
session_recording: {
maskAllInputs: boolean;
Expand Down Expand Up @@ -81,6 +82,7 @@ export function CloudAnalyticsProvider({
{
api_host: resolvedPosthogHost,
defaults: '2026-05-30',
capture_exceptions: true,
disable_session_recording: false,
session_recording: { maskAllInputs: true },
},
Expand Down
Loading