refactor(DAO-2005): migrate my-rewards date formatters to shared utilities [4/5] - #2103
Open
Freshenext wants to merge 1 commit into
Open
refactor(DAO-2005): migrate my-rewards date formatters to shared utilities [4/5]#2103Freshenext wants to merge 1 commit into
Freshenext wants to merge 1 commit into
Conversation
…ities
Remove formatExpandedDate, formatDateRange, and formatDateForCsv from
tx-history/utils. Consumers now import from @/lib/utils; formatDateRange
callers pass cycleDuration.as('seconds') instead of a Duration object.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatExpandedDate,formatDateRange, andformatDateForCsvfrom tx-history utilsDesktopDataRow,CsvButton, backer and builderconvertDataToRowDatato import from@/lib/utilsformatDateRangecallers now passcycleDuration.as('seconds')instead of a Duration object