fix(amux): fall back to default base when AMUX_API_BASE is empty#13
Merged
Conversation
env::var returns Ok("") for an env var set to an empty string (as
docker-compose passes ${AMUX_API_BASE:-} when unset), which would yield
an empty base URL. Filter empties so https://api.amux.ai still wins.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
I have read the Contributor License Agreement (CLA) and hereby sign the CLA. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores the empty-
AMUX_API_BASEfallback guard onmain.Why
maincurrently uses the naive form:unwrap_or_elseonly fires onErr(var missing). An env var set to the empty string returnsOk("")and slips through, leavingAMUX_API_BASE = ""— a broken base URL. That's exactly what docker-compose produces withAMUX_API_BASE: ${AMUX_API_BASE:-}when the host var is unset.The fix shipped on
feat/amux-seedance(cff4cfb) but was lost when the amux provider was squash-merged tomainas #12 (1e9dc55). This cherry-picks just that commit back ontomainso the default wins on an empty value as well as a missing one.Context
Consumed downstream by RouterBase/RouterBase#143 (submodule bump). Once this lands on
main, a future RouterBase pin can track the submodule'smaincleanly instead of thefeat/amux-seedanceSHA.🤖 Generated with Claude Code