Skip to content

testing: cover select and dropdown behavior#371

Merged
RtlZeroMemory merged 1 commit intofeature/testing-modal-dialog-focus-behaviorfrom
feature/testing-select-dropdown-behavior
Apr 14, 2026
Merged

testing: cover select and dropdown behavior#371
RtlZeroMemory merged 1 commit intofeature/testing-modal-dialog-focus-behaviorfrom
feature/testing-select-dropdown-behavior

Conversation

@RtlZeroMemory
Copy link
Copy Markdown
Owner

Summary

  • cover app-level select keyboard progression with disabled-option skipping and visible value updates
  • cover dropdown outside-click close at the app contract level while retaining the existing item-click selection coverage
  • keep the existing shared select scenario and lower-level dropdown routing/overlay suites in place

Families Covered

  • select
  • dropdown

Tests Added, Rewritten, Removed

  • added app-level tests in packages/core/src/app/__tests__/widgetBehavior.contracts.test.ts for select keyboard progression and dropdown outside-click close
  • rewrote no existing tests in this PR
  • removed no tests in this PR because the retained shared scenario and lower-level dropdown suites still protect keyboard routing, overflow windowing, and overlay ownership contracts

Implementation Bugs Fixed

  • none; the behavior-first tests passed once added

Commands Run

  • ./node_modules/.bin/tsc -b packages/core/tsconfig.json --pretty false
  • node --test packages/core/dist/app/__tests__/widgetBehavior.contracts.test.js
  • node --test packages/core/dist/testing/__tests__/referenceScenario.semantic.test.js
  • node --test packages/core/dist/app/__tests__/widgetRenderer.integration.test.js
  • node --test packages/core/dist/widgets/__tests__/dropdown.position.test.js packages/core/dist/runtime/__tests__/overlayUnification.test.js

Unresolved Areas Left Explicit

  • dropdown shortcut behavior remains covered at lower fidelity only; no new app-level shortcut assertion was added here
  • long-menu visible-window behavior remains protected by retained lower-level dropdown windowing tests rather than a new app-level contract test
  • table, tree, and virtual list re-audit remains separate from this PR

Dependency Note

#Closes 345

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 14, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aaf43b78-358f-4965-8f88-b6defc02f62c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/testing-select-dropdown-behavior

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@RtlZeroMemory RtlZeroMemory merged commit ac94d5d into feature/testing-modal-dialog-focus-behavior Apr 14, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant