Parse currencies not in CURRENCY_SYMBOLS #197
Merged
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunny
previously approved these changes
Jan 17, 2026
Member
sunny
left a comment
sunny
left a comment
There was a problem hiding this comment.
Nice fix. 👏🏻
Yeah, the logic should definitely be moved to money-heuristics at some point.
yukideluxe
previously approved these changes
Jan 17, 2026
Member
yukideluxe
left a comment
yukideluxe
left a comment
There was a problem hiding this comment.
Thanks for the fix! I also agree we should move that logic into the other gem!
Can you please a line in the CHANGELOG? 😳
Contributor
Author
|
That's one of those things I consistently forget 🤦♂️ |
Member
I am just surprised @sunny did not mention it 😈 No worries and thanks! 🙏🏻 |
yukideluxe
approved these changes
Jan 17, 2026
Member
|
Haha, good catch @yukideluxe 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187.
(I think the whole parsing of symbols (other than ISO codes) and multipliers belongs in money-heuristics)