Encore: 2 Bundled Encore Features and Settings UI Updates#419
Open
needmorecowbell wants to merge 19 commits intoRunMaestro:mainfrom
Open
Encore: 2 Bundled Encore Features and Settings UI Updates#419needmorecowbell wants to merge 19 commits intoRunMaestro:mainfrom
needmorecowbell wants to merge 19 commits intoRunMaestro:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EncoreFeatureCard, creating a flat, uniform feature list in Settings → Encore tabWhat's included
Core system (
src/main/encore-*.ts,src/shared/encore-types.ts):process:read,storage,settings:*,notifications,network)dist/encores/→userData/encores/.., absolute paths, null bytes, separators)encore:<id>:<channel>message routingUI (
src/renderer/components/):EncoreFeatureCard— shared toggle card wrapper used by both Director's Notes and PluginsDirectorNotesSettings— extracted ~380 LOC from SettingsModal into self-contained componentEncoreManager— browse/enable/disable encores with per-encore settings panelsEncoreTabContent— sandboxed iframe renderer for encores with UICtrl+Shift+Xopens Encore tab (when plugins feature enabled)State persistence fix:
userDisabledflag with symmetricencore:<id>:enabledbooleanenableEncore()→ sets true,disableEncore()→ sets false, startup restores only explicittrueTest plan
npm run lintpassesnpm run devrestarts; toggle off → stays off🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Documentation