Conversation
chore: synch up develop with main again
Agent-Logs-Url: https://github.com/RussellSB/pytrendy/sessions/3993dd13-fd55-4617-9e8b-0682b3c54b42 Co-authored-by: RussellSB <35470600+RussellSB@users.noreply.github.com>
RussellSB
left a comment
There was a problem hiding this comment.
Nitpick: is the git diff in pyproject.toml and changelog.md releveant to this PR? This might have come when the base branch was main, and I manually changed it to dev.
Investigate this, and so this doesn't happen with shenanigans, make sure that the base branch for agent PR requests is develop by default. Update the copilot skill for this
There was a problem hiding this comment.
Pull request overview
Adds a GitHub Actions workflow to build and publish per-PR documentation previews to GitHub Pages, with automated cleanup on PR close. The PR also includes a version bump and changelog entry that appear unrelated to the stated docs-preview purpose.
Changes:
- Add
.github/workflows/docs-preview.yamlto deploy PR-scoped MkDocs builds togh-pages/pr-{N}/and comment the preview URL on the PR. - Add a cleanup job to remove
pr-{N}/fromgh-pageswhen the PR is closed. - Update
pyproject.tomlversion and prepend a newCHANGELOG.mdentry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
.github/workflows/docs-preview.yaml |
New PR docs preview + teardown workflow targeting gh-pages/pr-{N}/ with PR commenting. |
pyproject.toml |
Bumps project version to 1.1.11. |
CHANGELOG.md |
Adds a new 1.1.11 release section at the top. |
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| comment_id: botComment.id, | ||
| body: `📚 **Docs preview removed**\n\nThe docs preview for this PR has been cleaned up.`, |
There was a problem hiding this comment.
Cleanup updates the PR comment body to 'Docs preview removed', which removes the 'Docs preview deployed' text used by the deploy job to locate and update the existing comment. This makes it likely that the next deploy will post a duplicate comment instead of updating the existing one. Keep the same marker text (or a hidden marker) in both the deploy and cleanup comment bodies so the comment remains discoverable.
| body: `📚 **Docs preview removed**\n\nThe docs preview for this PR has been cleaned up.`, | |
| body: `<!-- Docs preview deployed -->\n📚 **Docs preview removed**\n\nThe docs preview for this PR has been cleaned up.`, |
Co-authored-by: RussellSB <35470600+RussellSB@users.noreply.github.com>
Agent-Logs-Url: https://github.com/RussellSB/pytrendy/sessions/9590c86c-ccd9-4bf9-b81f-bd57c3ce8960 Co-authored-by: RussellSB <35470600+RussellSB@users.noreply.github.com>
Agent-Logs-Url: https://github.com/RussellSB/pytrendy/sessions/9590c86c-ccd9-4bf9-b81f-bd57c3ce8960 Co-authored-by: RussellSB <35470600+RussellSB@users.noreply.github.com>
The spurious diffs were caused by the branch being forked from Fixed in commits
|
…e push in cleanup Agent-Logs-Url: https://github.com/RussellSB/pytrendy/sessions/69f331ee-6fb1-4c47-b39c-ec62bf26f807 Co-authored-by: RussellSB <35470600+RussellSB@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
and enforce develop as default base branch in copilot instructions Co-authored-by: RussellSB <35470600+RussellSB@users.noreply.github.com>
.github/workflows/docs-preview.yamlfor PR docs previews.github/copilot-instructions.mdto mandatedevelopas default base branchpyproject.toml/CHANGELOG.mddiffs by aligning branch withdevelop<!-- docs-preview-bot -->for comment lookup so deploy/cleanup jobs always find the same comment regardless of its current textgit pull --rebase origin gh-pagesbefore push in cleanup to prevent non-fast-forward failures when concurrent jobs push togh-pages