atom: tests: Don't assume char signedness#115
Open
andhe wants to merge 1 commit intoRustAudio:developfrom
Open
atom: tests: Don't assume char signedness#115andhe wants to merge 1 commit intoRustAudio:developfrom
andhe wants to merge 1 commit intoRustAudio:developfrom
Conversation
For example on aarch64/arm64:
```
error[E0308]: mismatched types
--> tests/atom_integration.rs:91:14
|
91 | URI: LV2Map::URI.as_ptr() as *const i8,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*const u8`, found `*const i8`
|
= note: expected raw pointer `*const u8`
found raw pointer `*const i8`
error[E0308]: mismatched types
--> tests/atom_integration.rs:144:13
|
141 | let plugin = (plugin_descriptor.instantiate.unwrap())(
| ---------------------------------------- arguments to this function are incorrect
...
144 | b"\0".as_ptr() as *const i8,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*const u8`, found `*const i8`
|
= note: expected raw pointer `*const u8`
found raw pointer `*const i8`
For more information about this error, try `rustc --explain E0308`.
error: could not compile `lv2-atom` due to 2 previous errors
```
Contributor
|
This looks good to me: the field I don't have merging powers, but I have no objections against approving this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example on aarch64/arm64: