You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR adds bindings for 64-bit PowerPC (target_arch = "powerpc64"). I generated the bindings on a native ppc64le system, and in line with this commit, I added a repr(align(8)) to LV2_Atom.
This PR adds bindings for 64-bit PowerPC (target_arch = "powerpc64"). I generated the bindings on a native ppc64le system, and in line with this commit, I added a repr(align(8)) to LV2_Atom.
Can you explain how the bindings are generated? I used the command from sys/tool/README.md and it just fails with No such file or directory.
This works around two issues: the first is that the older version of bindgen used by the tool doesn't work with LLVM 16 or newer, so I manually configured LIBCLANG_PATH for LLVM 15, and the second is that the tool panics if you don't provide any extra arguments to Clang, so I just added -v.
I then manually added repr(align(8)) to LV2_Atom in the generated output, to match what was done for other architectures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds bindings for 64-bit PowerPC (
target_arch = "powerpc64"). I generated the bindings on a native ppc64le system, and in line with this commit, I added arepr(align(8))toLV2_Atom.