Trusted Publishing config tweaks #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of workspace-level config and tag names from `universal-hashes`
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1201 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 182 182
Lines 20528 20528
=======================================
Hits 17845 17845
Misses 2683 2683 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
newpavlov
reviewed
Feb 11, 2026
| CRATE_TOML_VERSION=$(grep "^version =" Cargo.toml | cut -d'"' -f2) | ||
| echo $CRATE_TOML_VERSION | ||
| [[ $CRATE_TOML_VERSION == $CRATE_VERSION ]] | ||
| [[ $CRATE_TOML_VERSION == $TAG_NAME ]] |
Member
There was a problem hiding this comment.
Have you tested this config? I think $CRATE_TOML_VERSION contains X.Y.Z, while $TAG_NAME contains vX.Y.Z, so the equality check will be always false.
Member
Author
There was a problem hiding this comment.
Not yet, this was adapting the other config to a single-crate repo
Member
There was a problem hiding this comment.
I think you need to keep the CRATE_VERSION=${TAG_NAME##*-v} part and modify it slightly or tweak the equality check to prepend v to $CRATE_TOML_VERSION.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of workspace-level config and tag names from
universal-hashes