Remove nlimbs! macro
#1202
Merged
Remove nlimbs! macro
#1202
+0
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it has the same name as the `nlimbs` function, it becomes impossible to import the `nlimbs` function without triggering the deprecation warning. (Possibly we could move the deprecation to inside the macro somehow)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1202 +/- ##
=======================================
Coverage 86.93% 86.93%
=======================================
Files 182 182
Lines 20528 20528
=======================================
Hits 17845 17845
Misses 2683 2683 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it has the same name as the
nlimbsfunction, it becomes impossible to import thenlimbsfunction without triggering the deprecation warning.(Possibly we could move the deprecation to inside the macro somehow)