Skip to content

ci: enable minimal-versions jobs #2293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newpavlov merged 4 commits into from
Feb 9, 2026
+50 −71
Merged

ci: enable minimal-versions jobs #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d791c4e
ci: enable `minimal-versions` jobs
newpavlov Feb 9, 2026
47efacb
run workflows on confg change
newpavlov Feb 9, 2026
bf493bd
tweak cmd for elliptic-curve
newpavlov Feb 9, 2026
537a039
tweack elliptic-curve cmd
newpavlov Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/aead.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: aead
on:
pull_request:
paths:
- ".github/workflows/aead.yml"
- "aead/**"
- "Cargo.*"
push:
Expand Down Expand Up @@ -47,11 +48,10 @@ jobs:
# - run: cargo build --target ${{ matrix.target }} --release --no-default-features --features heapless
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features rand_core

# TODO(tarcieri): re-enable after next `crypto-common` release
# minimal-versions:
# uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
# with:
# working-directory: ${{ github.workflow }}
minimal-versions:
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
Expand Down
15 changes: 3 additions & 12 deletions .github/workflows/cipher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,10 @@ jobs:
- run: cargo build --target ${{ matrix.target }} --features rand_core
- run: cargo build --target ${{ matrix.target }} --features block-padding

# TODO: use the reusable workflow after this crate will be part of the
# root workspace
minimal-versions:
if: false # disabled until we stop using pre-releases
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: RustCrypto/actions/cargo-cache@master
- uses: dtolnay/rust-toolchain@nightly
- uses: RustCrypto/actions/cargo-hack-install@master
- run: cargo update -Z minimal-versions
- uses: dtolnay/rust-toolchain@stable
- run: cargo hack test --release --feature-powerset
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/crypto-common.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: crypto-common
on:
pull_request:
paths:
- ".github/workflows/crypto-common.yml"
- "crypto-common/**"
- "Cargo.*"
push:
Expand Down Expand Up @@ -41,11 +42,10 @@ jobs:
targets: ${{ matrix.target }}
- run: cargo build --target ${{ matrix.target }}

# TODO(tarcieri): re-enable when `getrandom` has a crate release with `sys_rng`
# minimal-versions:
# uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
# with:
# working-directory: ${{ github.workflow }}
minimal-versions:
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
Expand Down
15 changes: 4 additions & 11 deletions .github/workflows/crypto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: crypto
on:
pull_request:
paths:
- ".github/workflows/crypto.yml"
- "crypto/**"
- "Cargo.*"
push:
Expand Down Expand Up @@ -44,17 +45,9 @@ jobs:
--features aead,cipher,digest,elliptic-curve,signature,universal-hash

minimal-versions:
if: false # disabled until we stop using pre-releases
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: RustCrypto/actions/cargo-cache@master
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly
- uses: RustCrypto/actions/cargo-hack-install@master
- run: cargo update -Z minimal-versions
- run: cargo hack test --release --feature-powerset
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/digest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: digest
on:
pull_request:
paths:
- ".github/workflows/digest.yml"
- "digest/**"
- "Cargo.*"
push:
Expand Down Expand Up @@ -41,11 +42,10 @@ jobs:
targets: ${{ matrix.target }}
- run: cargo build --target ${{ matrix.target }}

# TODO(tarcieri): re-enable after next `crypto-common` release
#minimal-versions:
# uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
# with:
# working-directory: ${{ github.workflow }}
minimal-versions:
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
Expand Down
18 changes: 6 additions & 12 deletions .github/workflows/elliptic-curve.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,18 +62,12 @@ jobs:
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features alloc,digest,ecdh,pem,pkcs8,sec1,serde

minimal-versions:
# Temporarily disabled until elliptic-curve 0.14.0 is published
if: false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: RustCrypto/actions/cargo-cache@master
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly
- uses: RustCrypto/actions/cargo-hack-install@master
- run: cargo update -Z minimal-versions
- run: cargo +stable build --release --all-features
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}
stable-cmd: |
cargo hack check --feature-powerset --no-dev-deps --skip basepoint-table
Copy link
Member Author

@newpavlov newpavlov Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcieri
Probably worth to tweak this command in a later PR since this tests 500+ combinations.

cargo check --all-features

test:
runs-on: ubuntu-latest
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/kdf.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: kdf
on:
pull_request:
paths:
- ".github/workflows/kdf.yml"
- "kdf/**"
- "Cargo.*"
push:
Expand Down Expand Up @@ -36,6 +37,11 @@ jobs:
targets: ${{ matrix.target }}
- run: cargo build --no-default-features --release --target ${{ matrix.target }}

minimal-versions:
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
strategy:
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/kem.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: kem
on:
pull_request:
paths:
- ".github/workflows/kem.yml"
- "kem/**"
- "Cargo.*"
push:
Expand Down Expand Up @@ -41,6 +42,11 @@ jobs:
targets: ${{ matrix.target }}
- run: cargo build --no-default-features --release --target ${{ matrix.target }}

minimal-versions:
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
strategy:
Expand Down
16 changes: 4 additions & 12 deletions .github/workflows/password-hash.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: password-hash
on:
pull_request:
paths:
- ".github/workflows/password-hash.yml"
- "password-hash/**"
- "Cargo.*"
push:
Expand Down Expand Up @@ -42,19 +43,10 @@ jobs:
- uses: RustCrypto/actions/cargo-hack-install@master
- run: cargo hack build --target ${{ matrix.target }} --feature-powerset --exclude-features getrandom

# TODO: use the reusable workflow after this crate will be part of the root workspace
minimal-versions:
if: false # disabled until we stop using pre-releases
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: RustCrypto/actions/cargo-cache@master
- uses: dtolnay/rust-toolchain@master
with:
toolchain: nightly
- uses: RustCrypto/actions/cargo-hack-install@master
- run: cargo update -Z minimal-versions
- run: cargo hack test --release --feature-powerset
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/signature.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: signature
on:
pull_request:
paths:
- ".github/workflows/signature.yml"
- "signature/**"
- "Cargo.*"
push:
Expand Down Expand Up @@ -44,7 +45,6 @@ jobs:
- run: cargo build --target ${{ matrix.target }} --release --no-default-features --features rand_core

minimal-versions:
if: false # disabled until we stop using pre-releases
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/universal-hash.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ name: universal-hash
on:
pull_request:
paths:
- ".github/workflows/universal-hash.yml"
- "universal-hash/**"
- "Cargo.*"
push:
Expand Down Expand Up @@ -41,11 +42,10 @@ jobs:
targets: ${{ matrix.target }}
- run: cargo build --no-default-features --release --target ${{ matrix.target }}

# TODO(tarcieri): re-enable after next `crypto-common` release
# minimal-versions:
# uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
# with:
# working-directory: ${{ github.workflow }}
minimal-versions:
uses: RustCrypto/actions/.github/workflows/minimal-versions.yml@master
with:
working-directory: ${{ github.workflow }}

test:
runs-on: ubuntu-latest
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/workspace.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ on:
- '**/CHANGELOG.md'
push:
branches: master
paths-ignore:
- '**/README.md'
- '**/CHANGELOG.md'

env:
CARGO_INCREMENTAL: 0
Expand Down