Skip to content

Implemented Django-allauth for user authentication#13

Open
prabs222 wants to merge 3 commits intoRyanWalker277:mainfrom
prabs222:main
Open

Implemented Django-allauth for user authentication#13
prabs222 wants to merge 3 commits intoRyanWalker277:mainfrom
prabs222:main

Conversation

@prabs222
Copy link
Copy Markdown

@prabs222 prabs222 commented Feb 7, 2023

Related Issues or bug

  • Implemented Django-allauth for user authentication

Fixes: #4

Proposed Changes

  • Implemented Django-allauth for user authentication.
  • Implemented Google SignUp and SignIn with django-allauth.
  • Same login screen is used for signing in.
  • Customised the default signup page.

@RyanWalker277
Copy link
Copy Markdown
Owner

On testing it on local , the registration page is throwing a connection refused error
You can take refrence from here https://stackoverflow.com/questions/57405472/connectionrefusederror-at-accounts-register to fix it

@RyanWalker277
Copy link
Copy Markdown
Owner

Also , there are some things which need work , I am making a checklist of all the points , make sure to complete it before requesting a second review

  • An authenticated user should always be redirected to dashboard on hitting the home route
  • Registration form fields should be properly rendered in the template
  • Remove the logout confirmation page
  • Fix the google sign in button on the login page , make it cover the proper length of the container

It is quite a big and hefty task and will require a few revisions , I will increase your points once the PR is merged to reward your efforts accordingly , so rest assured.

@prabs222
Copy link
Copy Markdown
Author

prabs222 commented Feb 8, 2023

@RyanWalker277 Sir I have completed all the tasks please review them.

@RyanWalker277
Copy link
Copy Markdown
Owner

Hey @prabs222 ! Nice work , just a few minor enhancements.

  • Add a redirect on registration page , to redirect the user on login page after a timeout of 5 seconds
  • Fix the route for the login button at the bottom of signup page
  • Add a prompt for wrong credentials on login screen
  • Fix the show password button on the login screen
  • Lastly , remove unnecessary comments from the code and document your changes properly in the codebase in the form of comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Django-allauth for user authentication

2 participants