Enhance pickup fields#27
Open
JustShah wants to merge 4 commits into
Open
Conversation
- Modified the shipment decorator to conditionally create pickup details only if 'pickup_day' is present in customer metadata. - Updated the order's customer metadata to include pickup details only if they are present.
JustShah
force-pushed
the
enhance-pickup-fields
branch
from
March 10, 2025 09:08
c42afe9 to
abf2d14
Compare
|
ok, perfect. |
Author
|
@fthobe Can you please help me understand the spacing issue? I double checked the code and found that the spacing between Shipping Method and Schedule Pickup is the same. Also, we want to add a third horizontal line (a new line between Shipping Method and Schedule Pickup). |
JustShah
force-pushed
the
enhance-pickup-fields
branch
from
March 10, 2025 10:35
abf2d14 to
4983a1d
Compare
- Improved the layout of pickup fields in the delivery step view. - Added a legend for better section identification. - Updated labels and select inputs to use localized strings.
- Added localization strings for pickup day, pickup time, next 5 business days, and available time slots.
JustShah
force-pushed
the
enhance-pickup-fields
branch
from
March 10, 2025 13:11
4983a1d to
6bd9652
Compare
|
The one under shipping method disappeared, please find the reference design below: |
Author
|
|
|
ok update the PR screenshot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements and updates related to the pickup fields in the delivery step view and the conditional creation of pickup details in the shipment decorator.
Changes Included:
Update Shipment Decorator to Conditionally Create Pickup Details:
pickup_dayis present in customer metadata.Enhance Pickup Fields Layout in Delivery Step View:
Add Localization for Pickup Fields:
These changes enhance the user experience by improving the layout and localization of the pickup fields, and ensure that pickup details are only created when necessary, based on the presence of
pickup_dayin customer metadata.