Add payment information fields#28
Open
JustShah wants to merge 4 commits into
Open
Conversation
|
@JustShah Looks much better now, one thing: |
JustShah
force-pushed
the
add-payment-information-fields
branch
from
March 10, 2025 09:46
2e139f2 to
d50df8b
Compare
|
Please also consider this comment:
Radio buttons are usually made in following order So the correct way would be:
This is how I would do it: H1 "Trade-In Payment Information""Please specify how you want to get paid. Please note that you can communicate your choice later, but it may delay your Trade-In."
Not now hides all related formfields. Also the shipping form field is vertical, we should do the same (do not invent style). |
JustShah
force-pushed
the
add-payment-information-fields
branch
2 times, most recently
from
March 10, 2025 10:30
ab8700e to
32d901c
Compare
JustShah
force-pushed
the
enhance-pickup-fields
branch
from
March 10, 2025 10:35
abf2d14 to
4983a1d
Compare
JustShah
force-pushed
the
add-payment-information-fields
branch
2 times, most recently
from
March 10, 2025 11:57
afb1d8b to
333497c
Compare
Author
JustShah
force-pushed
the
add-payment-information-fields
branch
2 times, most recently
from
March 10, 2025 12:35
fdb588a to
e4eb82f
Compare
JustShah
force-pushed
the
enhance-pickup-fields
branch
from
March 10, 2025 13:11
4983a1d to
6bd9652
Compare
- Created a new partial to render payment information fields for trade-in orders. - Included fields for payment method, account holder, and payment account. - Added a legend for better section identification. - Updated labels and select inputs to use localized strings.
- Added a new decorator for the CheckoutsController to handle permitted parameters based on the checkout state. - Included customer metadata in the permitted parameters for the delivery state.
- Moved the `trade_in_order?` method to the public section of the class for better accessibility.
- Added a JavaScript file to toggle the visibility of payment information fields based on the selected payment method. - Updated the install generator to include the new JavaScript file and append it to the solidus_starter_frontend.js manifest. - Updated the initializer template to set default configuration values for SolidusEasypost
JustShah
force-pushed
the
add-payment-information-fields
branch
from
March 10, 2025 13:28
e4eb82f to
2716721
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







This pull request includes several enhancements and updates related to the handling of trade-in orders, specifically focusing on adding payment information fields and improving parameter handling in the checkout process.
Changes Included:
Update Order Decorator to Refactor
trade_in_order?Method:trade_in_order?method to the public section of the class for better accessibility.Add Controller Decorator for Checkout Params Handling:
CheckoutsControllerto handle permitted parameters based on the checkout state.Add Payment Info Fields Partial for Trade-In Orders:
These changes enhance the functionality and user experience for trade-in orders by ensuring proper parameter handling and providing a dedicated section for entering payment information.

