Use default shipping calculator instead of easypost rate#37
Open
JustShah wants to merge 1 commit into
Open
Conversation
By default, the extension will pass the entire cost of shipping to the user. In order to override this logic and allowing admins on a per shipping method base to set either easypost or a default shipping rate calculator by setting use_default_shipping_calculator. The propsed change adds new boolean column to spree_shipping_methods to achieve the desired result.
|
Mayur, please explain to me how this corrisponds to the agreed approach from yesterday. We explicitly agreed to:
What happened? In Addition i Find the commit Message Lacks technical Detail helping me to understand why we did the opposite of what was discussed. |
Author
|
I thought all three of us agreed to make changes in There is no extensive changes are made in this file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR targets resolving issue#33 with following approach