Add reference field to shipment creation in SolidusEasypost#38
Open
JustShah wants to merge 1 commit into
Open
Conversation
This commit introduces a new `reference` field to the shipment creation process in the `SolidusEasypost::ShipmentBuilder` class. The `reference` is built using the order number and an optional customer reference from the order's metadata. This enhancement allows for better tracking and identification of shipments by including additional contextual information in the reference field.
|
@JustShah looks great, it's perfect including the if statement to avoid unneccessary empty spaces. Good work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new
referencefield to the shipment creation process in theSolidusEasypost::ShipmentBuilderclass. Thereferenceis built using the order number and an optional customer reference from the order's metadata. This enhancement allows for better tracking and identification of shipments by including additional contextual information in the reference field.Resolves: #12