Add a new column to prices to avoid editing pricing from the product interface if the price has been generated through a pricelist interface#19
Conversation
JustShah
force-pushed
the
6-add-the-optional-to-automatically-associate-users-to-groups-upon-signup
branch
2 times, most recently
from
c51f789 to
bed02f2
Compare
JustShah
force-pushed
the
9-add-a-new-column-to-prices-to-avoid-editing-pricing-from-the-product-interface-if-the-price-has-been-generated-through-a-pricelist-interface
branch
2 times, most recently
from
21da636 to
655795f
Compare
JustShah
force-pushed
the
6-add-the-optional-to-automatically-associate-users-to-groups-upon-signup
branch
from
bed02f2 to
7e52bb1
Compare
Implemented `check_pricelist_price` in variant API and price admin controllers to prevent the user from updating prices which are associated to a price list.
- Added a new localization key for the error message indicating that a price belongs to a price list and cannot be edited or deleted. - Updated the master variant price table and the general price table in the admin interface to: - Prevent editing and deleting of prices that belong to a price list. - Display a message indicating the associated price lists for prices that are part of a price list. These changes enhance user feedback and ensure that prices tied to price lists are clearly marked and protected from unintended modifications.
This change adds fields for contain_taxes and is_pricelist_price to price list item form.
JustShah
force-pushed
the
9-add-a-new-column-to-prices-to-avoid-editing-pricing-from-the-product-interface-if-the-price-has-been-generated-through-a-pricelist-interface
branch
from
655795f to
2f7681c
Compare
Author
|
created a new independent and improved PR: #22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several enhancements to the pricing management system within the Spree application, focusing on the integration of price lists. The changes aim to improve data integrity and user experience by preventing unintended modifications to prices associated with price lists.
Key Changes:
New Attributes for Prices:
contain_taxesandis_pricelist_priceattributes to the Spree price model. These attributes facilitate better management of pricing, particularly in relation to tax handling and price list associations.Price List Price Check:
check_pricelist_pricemethod in both the variant API and the admin prices controller. This method prevents users from updating or deleting prices that are associated with a price list, ensuring the integrity of pricing data.Localization and User Feedback:
Benefits: