Skip to content

Feature pre process#26

Open
YunliQi wants to merge 3 commits intodevfrom
feature-pre-process
Open

Feature pre process#26
YunliQi wants to merge 3 commits intodevfrom
feature-pre-process

Conversation

@YunliQi
Copy link
Contributor

@YunliQi YunliQi commented Feb 27, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 27, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3c860a0) to head (778e26f).
⚠️ Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev       #26   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines         1223      1228    +5     
=========================================
+ Hits          1223      1228    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@KCGallagher KCGallagher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YunliQi I am just trying to close up open PRs on these code bases. Have a look at the change I have suggested, but then I am happy for you to merge this code onto main.

Comment on lines +435 to 441
for t in range(max(time_sample) + 1):
num = self.time_data.iloc[t, 1:].value_counts().get(3, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(4, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(5, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(6, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(7, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(8, 0)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for t in range(max(time_sample) + 1):
num = self.time_data.iloc[t, 1:].value_counts().get(3, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(4, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(5, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(6, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(7, 0)
num += self.time_data.iloc[t, 1:].value_counts().get(8, 0)
true_result_plot = [
sum(self.time_data.iloc[t, 1:].value_counts().get(i, 0) for i in range(3, 9))
for t in range(max(time_sample) + 1)
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants