Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Written by Claude
Fixes from security review of the
variantopediaapp (SACGF/variantgrid_private#3817).Changes
Finding #1 — Replace
.objects.get()withget_object_or_404()variant_tag_detail()—Variantexport_classifications_allele()—Allelevariant_details_annotation_version()—AnnotationVersionnearby_variants()—AnnotationVersionFinding #3 — XSS via
|safein health check templateas_html()methods inlibrary/health_check.pynow useformat_html()so user-controlled content (usernames, HGVS strings, email subjects inextrafields) is properly escaped before being marked safe.Finding #4 — Missing authorization check in
variant_tag_detailPermissionDeniedif the user has no readableVariantTagfor the requested variant+tag.VariantTagDetailColumns): appliesVariantTag.filter_for_user()to the queryset so the datatable only returns tags the user has permission to see.