review app - permission and validation hardening#1515
Open
Conversation
…ivate#3827 - new_review() now checks view permission before rendering, consistent with edit_review() - Default lab pre-selection on new review filtered to only labs allowed for the reviewed object - MultiChoiceLabField.to_python() raises ValidationError on invalid lab PKs instead of KeyError - source_object resolution uses order_by('pk') for deterministic results - Remove invalid action attribute from csrf_token template tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of SACGF/variantgrid_private#3827.
Changes
new_review()permission check:new_review()now callsreview.check_can_view(request.user)before rendering, making it consistent withedit_review()which already did this.MultiChoiceLabFieldvalidation:to_python()now raises aValidationErroron unrecognised lab PKs instead of a bareKeyError(which would produce a 500).source_objectresolution: Addedorder_by('pk')to the.first()call so the result is stable rather than database-ordering-dependent.{% csrf_token %}cleanup: Removed a spuriousaction="{{ request.path }}"attribute that Django silently ignores — the form already defaults to the current URL.