Open
Conversation
- Validate `history` and `since` query params; return 400 on bad input - Remove dead `set_watcher()` call (method does not exist) - Handle DoesNotExist for FlagType and FlagResolution lookups; return 400 - Generic PermissionError messages to avoid leaking internal enum values - Omit lab affiliation from API responses for users other than the requester - Make flag_type read-only in FlagAdmin (should be immutable after creation)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…g error response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses SACGF/variantgrid_private#3830.
Changes
historyandsincequery parameters; return HTTP 400 on invalid input instead of raising an unhandled exceptionset_watcher()call — the method does not exist onFlagCollectionand would raiseAttributeErroron any POST with awatchparameterFlagType.DoesNotExistandFlagResolution.DoesNotExistin flag creation and resolution update paths; return HTTP 400 instead of 500PermissionErrormessages inflags/models/models.pyto avoid leaking internal implementation detailsflag_typeread-only inFlagAdmin— it should be immutable after flag creation