Added support for Switch+#44
Open
dcmeglio wants to merge 11 commits into
Open
Conversation
Owner
|
Considering. I just ordered myself a switch...
Thanks!
Barry
…Sent from my iPhone
On Aug 7, 2020, at 6:49 PM, dcmeglio ***@***.***> wrote:
I don't know if you'll be interested in merging this, but I added initial (Hubitat) support for Switch+'s. I know it's not thermostat related but the Hubitat default integration supports Switch+. I really didn't want to run two integrations (more hub resources used and I'm having 2 apps hit the Ecobee API). On top of this, your integration has MUCH better support for API disconnects and retries than the builtin Hubitat integration. So I figured I'd do it all through one app.
Some notes:
Only tested on Hubitat
I didn't even try to implement a ST tile as I have no way to test
Tested both when only switches are setup, and switch + thermostat mode
It'd be great if you considered integrating it so I don't have to keep my fork in sync with your apps!
You can view, comment on, or merge this pull request online at:
#44
Commit Summary
Initial work to support Switch+ devices
Improved logging
File Changes
A devicetypes/sandood/ecobee-suite-switch.src/ecobee-suite-switch.groovy (166)
M smartapps/sandood/ecobee-suite-manager.src/ecobee-suite-manager.groovy (418)
Patch Links:
https://github.com/SANdood/Ecobee-Suite/pull/44.patch
https://github.com/SANdood/Ecobee-Suite/pull/44.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
…o intention of ever merging this
|
I've got a Switch+ recently and I'm very interested in this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if you'll be interested in merging this, but I added initial (Hubitat) support for Switch+'s. I know it's not thermostat related but the Hubitat default integration supports Switch+. I really didn't want to run two integrations (more hub resources used and I'm having 2 apps hit the Ecobee API). On top of this, your integration has MUCH better support for API disconnects and retries than the builtin Hubitat integration. So I figured I'd do it all through one app.
Some notes:
It'd be great if you considered integrating it so I don't have to keep my fork in sync with your apps!