Skip to content

feat: [Grounding] Added GroundingClient.withHeader()#767

Merged
CharlesDuboisSAP merged 3 commits intomainfrom
header
Feb 25, 2026
Merged

feat: [Grounding] Added GroundingClient.withHeader()#767
CharlesDuboisSAP merged 3 commits intomainfrom
header

Conversation

@CharlesDuboisSAP
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP commented Feb 24, 2026

Context

AI/ai-sdk-java-backlog#358.

All relevant clients should support using custom headers

Feature scope:

  • Added GroundingClient.withHeader()

Definition of Done

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Feb 24, 2026
<coverage.line>71%</coverage.line>
<coverage.instruction>85%</coverage.instruction>
<coverage.branch>100%</coverage.branch>
<coverage.branch>75%</coverage.branch>
Copy link
Contributor Author

@CharlesDuboisSAP CharlesDuboisSAP Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caused by if (header.getValue() != null) {. I'm not testing the value to null because it will never be null and I prefer having the if rather that an IDE warning.

Copy link
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines -39 to +44
final GetPipelines allPipelines = api.getAllPipelines("reosurceGroup");
final GetPipelines allPipelines = api.getAllPipelines("resourceGroup");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@CharlesDuboisSAP CharlesDuboisSAP merged commit ef10888 into main Feb 25, 2026
8 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the header branch February 25, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants