feat(destination): Add parameter to bypass service retrieval from VCAP#6332
Merged
davidkna-sap merged 6 commits intomainfrom Feb 23, 2026
Merged
feat(destination): Add parameter to bypass service retrieval from VCAP#6332davidkna-sap merged 6 commits intomainfrom
davidkna-sap merged 6 commits intomainfrom
Conversation
davidkna-sap
force-pushed
the
davidkna-sap_destination-provider
branch
from
1eecc61 to
7dd3127
Compare
marikaner
reviewed
Feb 17, 2026
| service: DestinationFromServiceBindingOptions['service'] | ||
| ): Service | undefined { | ||
| if (typeof service === 'string') { | ||
| return JSON.parse(service) as Service; |
Contributor
There was a problem hiding this comment.
[req] My original thought was, that the string part of service is a replacement for destinationName. I even think we could xor service and destination name... Otherwise I think we should not allow passing a JSON string to be parsed - we can expect users to pass in a service as an object.
davidkna-sap
force-pushed
the
davidkna-sap_destination-provider
branch
from
b3b4ca8 to
72ce4a1
Compare
marikaner
reviewed
Feb 18, 2026
Comment on lines
100
to
108
| } & Xor< | ||
| { | ||
| /** | ||
| * A service binding to use directly instead of looking it up by name. Mandatory if no destination name is provided. | ||
| */ | ||
| service: Service; | ||
| }, | ||
| Pick<DestinationFetchOptions, 'destinationName'> | ||
| >; |
Contributor
There was a problem hiding this comment.
[req] Could you add a type test for this to make sure that it works as expected? I am not sure from merely looking at this...
davidkna-sap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related https://github.com/SAP/ai-sdk-js-backlog/issues/451