Fix #361#362
Merged
Merged
Conversation
eleumasc
added a commit
to eleumasc/project-foxhound
that referenced
this pull request
Mar 27, 2026
tmbrbr
reviewed
Mar 30, 2026
tmbrbr
reviewed
Mar 30, 2026
tmbrbr
reviewed
Mar 30, 2026
Contributor
|
We made some changes in #360 which remove the "native" property from the Taint structure, and as a result the TaintOperationFromContext function has changed to no longer include the native boolean argument. Can you rebase your branch against main? |
Contributor
Author
|
Done, it should be good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We added mochitests for the two involved methods, i.e., toLowerCase and normalize. As a proposed solution, we create a NewDependentString when required.