chore(ci): declare explicit permissions for read-default rollout#136
Merged
Conversation
The generate.yaml workflow runs 'git push' using the default GITHUB_TOKEN provided by actions/checkout. Once the org-wide flip to read-default GITHUB_TOKEN lands, that push will fail unless the workflow explicitly declares contents: write. This narrows the token's effective scope (was implicit write-everything; becomes read all + write contents) without changing happy-path behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declare explicit
permissions: contents: writeon.github/workflows/generate.yamlso the workflow continues to push regenerated artifacts after the org-wide flip to read-defaultGITHUB_TOKEN.Why
OSPO hardening — Finding 1:
restrict_default_workflow_permissions = truewill be enabled fleet-wide on the SAP CS-DevOps OSPO repo set. This workflow performsgit pushusing the defaultGITHUB_TOKENfromactions/checkout; without an explicit permissions block it will start failing under the read-only default.Risk
Low. We narrow the token's effective scope (currently implicit write-everything; becomes read all + write contents) instead of broadening it. No behavior change on the happy path — the workflow continues to push as before. Same change already merged on
cert-manager-cop(PR #129).Test plan