Skip to content

Eenhance banner component with flash and vs code icon theme support#936

Merged
kjose90 merged 4 commits intomasterfrom
yeoman-ui-banner
Feb 16, 2026
Merged

Eenhance banner component with flash and vs code icon theme support#936
kjose90 merged 4 commits intomasterfrom
yeoman-ui-banner

Conversation

@kjose90
Copy link
Copy Markdown
Member

@kjose90 kjose90 commented Feb 9, 2026

Related PR
internal tools-suite issue #36883

Enhanced the YOUIBanner component to support flash animation and SVG icons to adapt to VS Code theme

  • Animated Banner Support

    • Added animated property to banner configuration, if animated is true then banner displays a shine effect
  • Theme-Aware SVG Icons via v-html

    • Why v-htmlis required: To render base64-encoded SVG icons inline
      SVG icons automatically adapt to user's active theme (light/dark/high-contrast)
    • Uses --vscode-settings-headerForeground CSS variable for color consistency
    • Alternative approaches (e.g., <img src="data:image/svg...">) cannot access theme colors

@kjose90 kjose90 marked this pull request as ready for review February 9, 2026 13:46
@kjose90 kjose90 marked this pull request as draft February 9, 2026 16:21
@kjose90 kjose90 marked this pull request as ready for review February 10, 2026 10:31
/**
* Optional flag to enable animated on the banner
*/
animated?: true;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you probably meant -> animated?: boolean

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks.

Copy link
Copy Markdown
Contributor

@alex-gilin alex-gilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kjose90 kjose90 merged commit 81c4c17 into master Feb 16, 2026
3 checks passed
@kjose90 kjose90 deleted the yeoman-ui-banner branch February 16, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants