Skip to content

fix: suppport loading of application wizard/generators when using a virtual fs#939

Merged
vbangelov merged 5 commits intoSAP:masterfrom
longieirl:937/handle-virtual-filesystems
Feb 25, 2026
Merged

fix: suppport loading of application wizard/generators when using a virtual fs#939
vbangelov merged 5 commits intoSAP:masterfrom
longieirl:937/handle-virtual-filesystems

Conversation

@longieirl
Copy link
Copy Markdown
Contributor

@longieirl longieirl commented Feb 18, 2026 •
edited
Loading

  • tests updated
  • vsix installed and tested locally with change
  • change to support yeoman-ui being loaded when the workspace is loaded as a virtual fs
Screenshot 2026-02-18 at 11 22 52

Updated, Friday 20th Feb
yeoman-ui-1.22.0.vsix.txt

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Feb 18, 2026 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@longieirl longieirl changed the title fix: Suppport loading of application wizard/generators when using a virtual fs fix: suppport loading of application wizard/generators when using a virtual fs Feb 18, 2026
@longieirl longieirl closed this Feb 18, 2026
@longieirl longieirl reopened this Feb 18, 2026
@longieirl longieirl force-pushed the 937/handle-virtual-filesystems branch from 041b069 to adb6096 Compare February 18, 2026 11:31
@longieirl longieirl marked this pull request as ready for review February 18, 2026 11:42
devinea
devinea approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @longieirl
tested locally. Changes work well.
1 minor suggestion.

devinea
devinea approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix. Retested locally and works well with virtual (and non-virtual) filesystem.

@longieirl
Copy link
Copy Markdown
Contributor Author

longieirl commented Feb 18, 2026

@vbangelov @alex-gilin can you please review? Thanks.

alex-gilin
alex-gilin requested changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alex-gilin alex-gilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good.
But there are other modules (vscode-youi-events.ts, YeomanUIPanel.ts) that reference vscode.workspace.workspaceFolders -> IMHO, the same filter should be applied there as well.

@longieirl
Copy link
Copy Markdown
Contributor Author

longieirl commented Feb 20, 2026

Overall, it looks good. But there are other modules (vscode-youi-events.ts, YeomanUIPanel.ts) that reference vscode.workspace.workspaceFolders -> IMHO, the same filter should be applied there as well.

Thank you.
Comments addressed and vsix with changes uploaded.
I dont think I've tested all the flows since I'm not familiar with different paths to ensure my changes are covered.

alex-gilin
alex-gilin approved these changes Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alex-gilin alex-gilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@longieirl longieirl requested a review from devinea February 20, 2026 10:49
devinea
devinea approved these changes Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving after latest changes.
Code looks good. Haven't tested the additional flows.

@longieirl
Copy link
Copy Markdown
Contributor Author

longieirl commented Feb 24, 2026

@rimasirich @vbangelov can you please review and merge if you happy with the changes? Thanks.

vbangelov
vbangelov approved these changes Feb 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vbangelov vbangelov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vbangelov vbangelov merged commit d9ee7d0 into SAP:master Feb 25, 2026
3 checks passed
@longieirl longieirl deleted the 937/handle-virtual-filesystems branch February 25, 2026 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-gilin alex-gilin alex-gilin approved these changes

@vbangelov vbangelov vbangelov approved these changes

+1 more reviewer

@devinea devinea devinea approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longieirl @devinea @alex-gilin @vbangelov