fix: unreachable 404 check in DELETE /api/generate/[id]#232
Merged
SATYAM-PRATIBHAN merged 1 commit intoMay 27, 2026
Merged
Conversation
👷 Deploy request for arcmind-ai pending review.Visit the deploys page to approve it
|
Contributor
Author
|
@SATYAM-PRATIBHAN, Hi kindly check this PR and let me know, Thank U!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an unreachable 404 check in the DELETE handler of
/api/generate/[id]. Prisma's.delete()throws aP2025error when the record doesn't exist — it never returnsnull. The existingif (!generation)check afterdelete()was dead code, causing users to receive a 500 instead of a proper 404.The fix replaces direct
delete()with afindFirst()check first. If the generation is not found, we return 404 immediately. Only then do we calldelete().Type of Change
Related Issues
Fixes #231
Checklist
Requested Labels
GSSoC 2026 , gssoc:approved , level:beginner , quality:clean , type:refactor