Feature/howard v09 72 00 08 harps - #89
Draft
brucehoward-physics wants to merge 3 commits into
Draft
Conversation
…in as 2d hits of type HIT_CUSTOM
…y the Vertex Creation algorithm previously committed.
…n but copying them over for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure the best way to have code for a data cross-check approved without actually merging it into the code base at the moment, but figure maybe getting some sort of branch which has undergone "approvals" or "checking over" might be a good start. Hence, making this draft PR as we don't actually want to merge it yet, but to have it checked out. Someone should let me know if they think of a better procedure.
Tagging Alice as reviewer for the moment due to relevant reconstruction expertise. Maybe someone like Dom Brailsford would also be a good reviewer given the Pandora nature of the edits: perhaps we should add him.
These are changes to enable post-HARPs reconstruction, namely the use of a custom vertex determined from LArSoft (in HARPS) to use in Pandora.
At some point we will actually want to merge this sort of modification into pandora/larsoft for broader use.